Implement enter end exit animation for Dialog #2374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

ASalavei merged 22 commits into jb-main from andrei.salavei/animate-dialog-appearance

Oct 28, 2025

ASalavei commented Sep 1, 2025 •

edited

Loading

Animation
iOS:

Simulator.Screen.Recording.-.iPhone.16.-.2025-10-23.at.16.01.19.mp4

Desktop:

Screen.Recording.2025-10-23.at.15.50.47.mov

Comparing with Android:

Screen.Recording.2025-09-01.at.16.03.32.mov

Fixes https://youtrack.jetbrains.com/issue/CMP-4365/iOS-iOS-Dialog-has-no-enter-and-exit-animation

(The feature was reverted due to https://youtrack.jetbrains.com/issue/CMP-9179/Desktop-Web-Crash-when-closing-ModalWideNavigationRail)

Release Notes

N/A

ASalavei added 3 commits

September 1, 2025 16:06


          Implement enter end exit animation for Dialog

c8093a1


          Make scrim darker

50fac7b


          Revert scrim color

c3d0949

ASalavei requested review from igordmn, m-sasha and svastven

September 1, 2025 14:25

ASalavei changed the title ~~Andrei.salavei/animate dialog appearance~~ Implement enter end exit animation for Dialog

m-sasha commented Sep 1, 2025

I'm not sure this is a good idea, in several aspects:

Dialog feels like a fairly low-level API (it's in ui). Should it even have an animation? That feels like it should be added at a higher-level API.
Should the animation be hardcoded, without allowing customization by anyone? On Android, is the animation also hardcoded, or is it a native dialog, with system/vendor-specific animation?
Should the animation be the same on all platforms? Should it be the one Android uses?

ApoloApps commented Sep 1, 2025

Customization is key! There should be a default value trying to mimic platform behaviour (per Os and platform like IOS, MacOs, Windows, etc) but it should still be customizable on dev's side

ASalavei marked this pull request as draft

September 2, 2025 07:05


          Add dialog animation

a4c8084

Author

ASalavei commented Sep 2, 2025 •

edited

Loading

@m-sasha , thanks for the feedback. If you have any ideas how to organize the API, please let me know.

Dialog feels like a fairly low-level API (it's in ui). Should it even have an animation? That feels like it should be added at a higher-level API.

As animation is a behaviour defined by the platform itself, it seems reasonable to define the basic animation in the 'ui' module. However, there are caveats, which I will explain further in the text.

Should the animation be hardcoded, without allowing customization by anyone?

It's good that you raised this question. To answer it, we must consider that a Popup is not equivalent to an Alert Dialog (or UIAlertController on iOS) — it can be used for a much wider range of use-cases. For this reason, I don't think we need to copy all the Alert Dialog animation variations for all the platforms and their various versions. It's much better to add a common wrapper around the system controls to have the native alerts than to mimic their behaviour.
However, I think the animation customisation API could be useful. Please take a look at the new public API that I added.

On Android, is the animation also hardcoded, or is it a native dialog, with system/vendor-specific animation?

On Android they are using Compose code to draw the Dialog's content and platform-provided scrim/appearance animations.

Should the animation be the same on all platforms?

I don't have a strong opinion on that; it's a question for the designers. What I am sure about is that we should not blindly copy the alert animation as the dialog animation.

Should it be the one Android uses?

Until we have design opinion, I'd go with the one used on Android.

Author

ASalavei commented Sep 2, 2025

@ApoloApps , please read my comment to @m-sasha .

Dialogs can also be used for UI like this. I don't think they should have the same animation as alerts.

ASalavei added 2 commits

September 2, 2025 10:30


          Update API dump

c979384


          Add experimental attributes

6a9351b

MatkovIvan requested changes

View reviewed changes

compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/window/Dialog.skiko.kt Outdated Show resolved Hide resolved

compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/window/Dialog.skiko.kt Outdated Show resolved Hide resolved

ASalavei added 2 commits

October 23, 2025 14:25


          Merge branch 'refs/heads/jb-main' into andrei.salavei/animate-dialog-…

0cc3556

…appearance

# Conflicts:
#	compose/ui/ui/api/desktop/ui.api
#	compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/window/Dialog.skiko.kt


          Update dialog animation

8e4ee3b

ASalavei requested a review from MatkovIvan

October 23, 2025 14:06

ASalavei marked this pull request as ready for review

October 23, 2025 14:11


          Add animation scale factor

49d676d

ASalavei marked this pull request as draft

October 23, 2025 14:56

ASalavei added 3 commits

October 24, 2025 13:40


          Merge branch 'refs/heads/jb-main' into andrei.salavei/animate-dialog-…

cc65506

…appearance


          Fix interop views placement dialog animation

3c1022f


          Fix dialog render test

3f714e0

MatkovIvan reviewed

View reviewed changes

compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/ImageComposeSceneTest.kt Outdated Show resolved Hide resolved

compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/window/Dialog.skiko.kt Outdated Show resolved Hide resolved

compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/window/Dialog.skiko.kt Outdated Show resolved Hide resolved

compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/window/Dialog.skiko.kt Outdated Show resolved Hide resolved


          MR comments fix

29451c3

ASalavei requested a review from MatkovIvan

October 27, 2025 09:41

m-sasha reviewed

View reviewed changes

m-sasha left a comment

Not a complete review, but we talked offline about a possible refactoring before continuing with the review.

compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/ImageComposeSceneTest.kt Outdated Show resolved Hide resolved

compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/window/Dialog.skiko.kt Outdated Show resolved Hide resolved

compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/window/Dialog.skiko.kt Outdated Show resolved Hide resolved


          Refactor dialog, update tests

8ed291c


          Update modifier

a812414

ASalavei requested review from MatkovIvan and m-sasha

October 27, 2025 13:14

MatkovIvan reviewed

View reviewed changes

compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/window/Dialog.skiko.kt Show resolved Hide resolved


          Fix issue with dynamic scrim color change

7000ac1

ASalavei requested a review from MatkovIvan

October 27, 2025 14:39


          Remove launched effect

1c3c4aa

ASalavei marked this pull request as ready for review

October 27, 2025 14:53

MatkovIvan approved these changes

View reviewed changes

svastven reviewed

View reviewed changes

compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/ImageComposeSceneTest.kt Outdated Show resolved Hide resolved

compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/window/Dialog.skiko.kt Outdated Show resolved Hide resolved


          PR Comments

690f180

ASalavei requested review from MatkovIvan and svastven

October 28, 2025 11:13

svastven approved these changes

View reviewed changes

m-sasha suggested changes

View reviewed changes

compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/TestUtils.kt Outdated Show resolved Hide resolved

compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/window/Dialog.skiko.kt Outdated Show resolved Hide resolved

compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/window/Dialog.skiko.kt Outdated Show resolved Hide resolved

compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/window/Dialog.skiko.kt Show resolved Hide resolved


          Refactor dialog animator

1b70e24

MatkovIvan reviewed

View reviewed changes

compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/window/Dialog.skiko.kt Outdated Show resolved Hide resolved

ASalavei requested review from MatkovIvan and m-sasha

October 28, 2025 13:21

ASalavei added 2 commits

October 28, 2025 15:31


          PR comments

b362780


          PR comments

8fc63e4

MatkovIvan approved these changes

View reviewed changes

m-sasha reviewed

View reviewed changes

compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/window/Dialog.skiko.kt Outdated Show resolved Hide resolved

m-sasha approved these changes

View reviewed changes

m-sasha left a comment

Other than the name of showDialog, looks good to me.


          PR comments

355d27a

ASalavei merged commit 8903902 into jb-main

15 of 16 checks passed

ASalavei deleted the andrei.salavei/animate-dialog-appearance branch

October 28, 2025 15:52

ASalavei added a commit that referenced this pull request


          Revert "Implement enter end exit animation for Dialog (#2374)"

aec2373

This reverts commit 8903902.

ASalavei mentioned this pull request

Revert "Implement enter end exit animation for Dialog (#2374)" #2537

Merged

ASalavei added a commit that referenced this pull request


          Revert "Implement enter end exit animation for Dialog (#2374)" (#2537)

f410470

This reverts commit 8903902. (#2374)

Fixes: https://youtrack.jetbrains.com/issue/CMP-9179

## Release Notes
N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet